Skip to content

Conversation

KarelZe
Copy link
Contributor

@KarelZe KarelZe commented Jun 3, 2025

With https://github.com/microsoft/onnxscript/pull/2039/files support for function-based rewriting was dropped. Some tutorials and the the readme were still referencing function-based rewrites.

@justinchuby / @gramalingam Could you please review? Any feedback is appreciated.

Copy link
Collaborator

@justinchuby justinchuby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@github-project-automation github-project-automation bot moved this from Todo to Done in ONNX Script Review Board Jun 3, 2025
@justinchuby justinchuby added the topic: documentation Improvements or additions to documentation label Jun 3, 2025
Copy link

codecov bot commented Jun 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.22%. Comparing base (c7d5786) to head (7588c0f).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2359   +/-   ##
=======================================
  Coverage   70.22%   70.22%           
=======================================
  Files         197      197           
  Lines       24742    24742           
  Branches     2650     2650           
=======================================
  Hits        17375    17375           
  Misses       6451     6451           
  Partials      916      916           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justinchuby justinchuby enabled auto-merge (squash) June 3, 2025 13:09
@justinchuby justinchuby disabled auto-merge June 3, 2025 13:11
@KarelZe KarelZe requested a review from justinchuby June 3, 2025 14:58
@justinchuby justinchuby enabled auto-merge (squash) June 5, 2025 22:33
@justinchuby justinchuby merged commit af452c7 into microsoft:main Jun 5, 2025
26 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: documentation Improvements or additions to documentation
Projects
Development

Successfully merging this pull request may close these issues.

2 participants