Skip to content

Fix proto handling in version converter #2411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2025
Merged

Fix proto handling in version converter #2411

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion onnxscript/version_converter/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,5 +169,5 @@
if model_proto is not None:
# Update the model proto in-place
model_proto.graph.Clear()
del model_proto.functions
del model_proto.functions[:]

Check warning on line 172 in onnxscript/version_converter/__init__.py

View check run for this annotation

Codecov / codecov/patch

onnxscript/version_converter/__init__.py#L172 

Added line #L172 was not covered by tests
model_proto.graph.CopyFrom(ir.to_proto(model.graph))
Loading