[pass] Enable DeduplicateInitializersPass #2416
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2416 +/- ##
==========================================
+ Coverage 69.31% 69.32% +0.01%
==========================================
Files 204 204
Lines 25850 25854 +4
Branches 2694 2696 +2
==========================================
+ Hits 17917 17923 +6
+ Misses 7002 7001 -1
+ Partials 931 930 -1 ☔ View full report in Codecov by Sentry. |
|
Looks like we need to expose |
|
But it is, I wonder why even for the onnx-ir-git workflow |
|
oh. We should switch to import onnx-ir by now |
|
I thought it was the version of ir. |
|
No I think it’s because we re exposed the passes under onnxscript ir |
justinchuby
reviewed
Jun 25, 2025
justinchuby
approved these changes
Jun 30, 2025
|
Looks like the pass was not actually added? @titaiwangms |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.