Skip to content

Reorder optimization passes #2433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 3, 2025
Merged

Reorder optimization passes #2433

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8570269
Reorder optimization passes
gramalingam Jul 2, 2025
d7f0fa8
Update assertion
gramalingam Jul 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion onnxscript/optimizer/_function_folding_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ def test_fold_nested_if_function_succeeds(self):
optimized = optimizer.optimize(model, onnx_shape_inference=False, inline=True)

self.assertEqual(len(optimized.functions), 0)
self.assertEqual(len(optimized.graph), 2)
self.assertEqual(len(optimized.graph), 1)
self.assertNotIn("If", {n.op_type for n in optimized.graph})


Expand Down
4 changes: 2 additions & 2 deletions onnxscript/optimizer/_optimizer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,10 +53,10 @@ def optimize_ir(
early_stop=stop_if_no_change,
),
common_passes.RemoveUnusedNodesPass(),
common_passes.CommonSubexpressionEliminationPass(),
common_passes.LiftConstantsToInitializersPass(),
common_passes.LiftConstantsToInitializersPass(lift_all_constants=True, size_limit=0),
common_passes.LiftSubgraphInitializersToMainGraphPass(),
common_passes.DeduplicateInitializersPass(),
common_passes.CommonSubexpressionEliminationPass(),
]
if inline:
# Inline all functions first before optimizing
Expand Down
Loading