Disable unstable tests #2512
Merged
Disable unstable tests #2512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2512 +/- ##
=======================================
Coverage 70.08% 70.08%
=======================================
Files 215 215
Lines 25872 25872
Branches 2605 2605
=======================================
Hits 18133 18133
Misses 6838 6838
Partials 901 901 ☔ View full report in Codecov by Sentry. |
Signed-off-by: xadupre <xadupre@microsoft.com>
justinchuby
reviewed
Aug 26, 2025
Signed-off-by: xadupre <xadupre@microsoft.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
justinchuby
reviewed
Aug 27, 2025
justinchuby
reviewed
Aug 27, 2025
justinchuby
reviewed
Aug 27, 2025
justinchuby
reviewed
Aug 27, 2025
justinchuby
reviewed
Aug 27, 2025
justinchuby
reviewed
Aug 27, 2025
justinchuby
reviewed
Aug 27, 2025
|
I assume that none of the disabled tests are "required" right now? If so, I guess it is relatively safe to merge this PR. |
Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com>
Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com>
Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com>
Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com>
Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com>
Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com>
justinchuby
approved these changes
Aug 28, 2025
|
Looks like onnxscript/backend/onnx_export_test.py is still being run on windows: https://github.com/microsoft/onnxscript/actions/runs/17290581699/job/49077106681?pr=2512 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tests never pass but are not blocking to merge the PR. It saves some time to disable them.