-
Notifications
You must be signed in to change notification settings - Fork 81
Update urls for pytorch documentation #2521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2521 +/- ##
=======================================
Coverage 70.06% 70.06%
=======================================
Files 215 215
Lines 25839 25839
Branches 2598 2598
=======================================
Hits 18104 18104
Misses 6837 6837
Partials 898 898 ☔ View full report in Codecov by Sentry. |
Optional[UINT32], | ||
Optional[UINT64], | ||
Optional[UINT8], | ||
None, |
Check warning
Code scanning / lintrunner
RUFF/RUF036 Warning
See https://docs.astral.sh/ruff/rules/none-not-at-end-of-union
Optional[UINT32], | ||
Optional[UINT64], | ||
Optional[UINT8], | ||
None, |
Check warning
Code scanning / lintrunner
RUFF/RUF036 Warning
See https://docs.astral.sh/ruff/rules/none-not-at-end-of-union
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
onnxscript/onnx_opset/_impl is auto generated - we cannot create manual changes to them. I would suggest reverting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can still keep the changes here and in the sphinx docs
pytorch updated its url.