Skip to content

Conversation

xadupre
Copy link
Member

@xadupre xadupre commented Aug 27, 2025

pytorch updated its url.

Copy link

codecov bot commented Aug 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.06%. Comparing base (6bf856e) to head (dd22584).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2521   +/-   ##
=======================================
  Coverage   70.06%   70.06%           
=======================================
  Files         215      215           
  Lines       25839    25839           
  Branches     2598     2598           
=======================================
  Hits        18104    18104           
  Misses       6837     6837           
  Partials      898      898           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Optional[UINT32],
Optional[UINT64],
Optional[UINT8],
None,

Check warning

Code scanning / lintrunner

RUFF/RUF036 Warning

None not at the end of the type annotation..
See https://docs.astral.sh/ruff/rules/none-not-at-end-of-union
Optional[UINT32],
Optional[UINT64],
Optional[UINT8],
None,

Check warning

Code scanning / lintrunner

RUFF/RUF036 Warning

None not at the end of the type annotation..
See https://docs.astral.sh/ruff/rules/none-not-at-end-of-union
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

onnxscript/onnx_opset/_impl is auto generated - we cannot create manual changes to them. I would suggest reverting

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can still keep the changes here and in the sphinx docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants