Skip to content

Conversation

justinchuby
Copy link
Collaborator

According to https://onnx.ai/onnx/operators/onnx__SplitToSequence.html#summary, If the argument split is not specified, a default scalar value of 1 is used as the value of split, and this is the only case when keepdims can be set to 0.

Fixes #2533

@justinchuby justinchuby added the module: torchlib Related to the torch/aten function lib in development label Sep 2, 2025
Copy link

codecov bot commented Sep 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.02%. Comparing base (07f3e4c) to head (fbfee99).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2536      +/-   ##
==========================================
+ Coverage   70.00%   70.02%   +0.01%     
==========================================
  Files         215      215              
  Lines       25992    25991       -1     
  Branches     2606     2606              
==========================================
+ Hits        18196    18200       +4     
+ Misses       6896     6891       -5     
  Partials      900      900              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justinchuby justinchuby added this to the 0.4.1 milestone Sep 2, 2025
@justinchuby justinchuby requested a review from xadupre September 2, 2025 19:35
@justinchuby justinchuby enabled auto-merge (squash) September 2, 2025 22:38
Copy link
Contributor

@titaiwangms titaiwangms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like the wording in ONNX spec for mutually exclusive attribute/input is ambiguous: Keep the split dimension or not. Default 1, which means we keep split dimension. If input ‘split’ is specified, this attribute is ignored.

@justinchuby justinchuby merged commit 7b04774 into main Sep 3, 2025
32 checks passed
@justinchuby justinchuby deleted the justinchu/aten_unbind branch September 3, 2025 17:07
@github-project-automation github-project-automation bot moved this from Todo to Done in ONNX Script Review Board Sep 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: torchlib Related to the torch/aten function lib in development
Projects
Development

Successfully merging this pull request may close these issues.

Conversion mismatch for aten::unbind.int
2 participants