[rewriter] Remove generic pattern matcher #2567
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is obsolete and the capability is covered by the simple pattern matcher Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
justinchuby
commented
Sep 18, 2025
| ("matcher_algo",), | ||
| [ | ||
| (generic_pattern.GenericPatternMatcher,), | ||
| (pattern.SimplePatternMatcher,), |
There was a problem hiding this comment.
Maybe we want to move some tests
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2567 +/- ##
==========================================
- Coverage 70.32% 70.10% -0.22%
==========================================
Files 222 220 -2
Lines 26659 26086 -573
Branches 2667 2575 -92
==========================================
- Hits 18747 18287 -460
+ Misses 6994 6903 -91
+ Partials 918 896 -22 ☔ View full report in Codecov by Sentry. |
gramalingam
approved these changes
Sep 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is obsolete and the capability is covered by the simple pattern matcher.