Skip to content

[torchlib] Simplify linalg_vector_norm to remove the redundant Abs #2570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 23, 2025
Merged

[torchlib] Simplify linalg_vector_norm to remove the redundant Abs #2570

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f7b577b
[torchlib] Simplify linalg_vector_norm to remove the redundant Abs
justinchuby Sep 23, 2025
87f4aac
update
justinchuby Sep 23, 2025
5a8e7ee
comment
justinchuby Sep 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion onnxscript/function_libs/torch_lib/ops/linalg.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,8 +330,9 @@ def aten_linalg_vector_norm(
keepdim = False
else:
dim = op.Reshape(dim, op.Constant(value_ints=[-1]))
self = op.Abs(self)

if math.isinf(ord):
self = op.Abs(self)
if ord > 0:
return op.ReduceMax(self, dim, keepdims=keepdim)
else:
Expand All @@ -345,6 +346,9 @@ def aten_linalg_vector_norm(
elif ord == 2.0:
return op.ReduceL2(self, dim, keepdims=keepdim)
else:
if ord < 0 or ord % 2 != 0:
# Not an even integer (could be odd, fractional or negative), use Abs
self = op.Abs(self)
self_pow = op.Pow(self, ord)
exp = op.CastLike(1 / ord, self)
return op.Pow(op.ReduceSum(self_pow, dim, keepdims=keepdim), exp)
Loading