Skip to content
This repository has been archived by the owner on May 6, 2022. It is now read-only.

Commit

Permalink
Merge pull request #3 from seecrypt/fix-comment-backslashes
Browse files Browse the repository at this point in the history 
Fixes builds where environment variable has backslashes
  • Loading branch information
@khouzam
khouzam committed Jan 8, 2015
2 parents b2a3b85 + 0c9ac1b commit c20688d
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions ms/do_vsproject.pl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ sub processBatch{
my $var = (split('=',$words[1]))[0];
my $val = substr($line, $ind+1);
$env{$var}=$val;
$function.=tab()."//set $var=$env{$var}\n";
$function.=tab()."//set $var=\"$env{$var}\"\n";
next;
}

Expand Down Expand Up @@ -257,7 +257,7 @@ sub processBatch{
my $var = (split('=',$line))[0];
my $val = substr($line, $ind+1);
$env{$var}=$val;
$function.=tab()."//$var=$env{$var}\n";
$function.=tab()."//$var=\"$env{$var}\"\n";
next;
}
if(index($line,":")!=-1)
Expand Down

3 comments on commit c20688d

@am11
Copy link

@am11 am11 commented on c20688d Jan 29, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@khouzam, would be really nice if you guys can fix this issue nodejs/node#478 in openssl source for VS2015.
//cc @rvagg

@khouzam
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can take a look at this, I'm actually working on VS 2015 support but haven't hit this particular issue. Can you give me more details about your setup and how you build?

@rvagg
Copy link

@rvagg rvagg commented on c20688d Jan 30, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@khouzam just this tiny modification in e_os.h: https://github.com/iojs/io.js/pull/478/files#diff-1 from memory it was just a link problem for openssl-cli.exe pointing to a missing __iob_func, ensuring that block wasn't invoked for 2015 does the trick

Please sign in to comment.