Skip to content
This repository was archived by the owner on Jun 6, 2024. It is now read-only.

[Web Portal] New job detail page #2297

Merged
merged 15 commits into from
Mar 19, 2019
Merged

[Web Portal] New job detail page #2297

merged 15 commits into from
Mar 19, 2019

Conversation

sunqinzheng
Copy link
Contributor

@sunqinzheng sunqinzheng commented Mar 11, 2019 •
edited
Loading

#2211
#2290
plugin job clone is also implemented in this pr

@sunqinzheng sunqinzheng requested review from Gerhut and abuccts March 11, 2019 05:57
@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 52.649% when pulling a0e31e8 on qinsu/job-detail into ea36fea on master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 52.649% when pulling a0e31e8 on qinsu/job-detail into ea36fea on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 52.649% when pulling a0e31e8 on qinsu/job-detail into ea36fea on master.

@coveralls
Copy link

coveralls commented Mar 11, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.01%) to 52.649% when pulling c85a2af on qinsu/job-detail into 6e0a52a on master.

abuccts
abuccts reviewed Mar 11, 2019
View reviewed changes
src/webportal/src/app/job/job-view/fabric/tachyons.css
@@ -0,0 +1,2152 @@
/* TACHYONS v0.0.1 | https://github.com/tachyons-css/tachyons */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you modified this file? Can we add it as a dependence?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. It's a tachyons css without normalize.css generated by tachyons generator.

@abuccts
Copy link
Member

abuccts commented Mar 11, 2019 •
edited
Loading

CORS issue when fetching stdout and stderr logs from hadoop.

@sunqinzheng
Copy link
Contributor Author

CORS issue when fetching stdout and stderr logs from hadoop.

The portal and hadoop will have the same origin if PAI is deployed with Pylon.
@Gerhut will add cors header to hadoop later for debugging and PAI without Pylon

@Gerhut
Copy link
Member

Gerhut commented Mar 12, 2019

CORS issue when fetching stdout and stderr logs from hadoop.

The portal and hadoop will have the same origin if PAI is deployed with Pylon.
@Gerhut will add cors header to hadoop later for debugging and PAI without Pylon

#2303

@sunqinzheng sunqinzheng merged commit 270ad27 into master Mar 19, 2019
@sunqinzheng sunqinzheng deleted the qinsu/job-detail branch March 19, 2019 06:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
2 more reviewers

@abuccts abuccts abuccts left review comments

@Gerhut Gerhut Gerhut approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sunqinzheng @coveralls @abuccts @Gerhut