Skip to content
This repository has been archived by the owner on Jun 6, 2024. It is now read-only.

[Web Portal] job submission page css tweak #3041

Merged
merged 1 commit into from
Jul 2, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/webportal/src/app/components/monaco-hack.scss
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,11 @@
}
}
}

:global {
.monaco-aria-container {
position: absolute;
left: -999em;
top: -999em;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ export const CommandSection = (props) => {
monacoProps={{height: 200}}
value={value}
onChange={_onChange}
completionItems={[...PAI_ENV_VAR.map((x) => `$${x.key}`)]}
completionItems={[...PAI_ENV_VAR.map((x) => x.key)]}
/>
</FormShortSection>
</BasicSection>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
*/

import {camelCase} from 'lodash';
import {TextField, IconButton, Stack, DetailsList, CheckboxVisibility, DetailsListLayoutMode, CommandBarButton, getTheme} from 'office-ui-fabric-react';
import {TextField, IconButton, Stack, DetailsList, CheckboxVisibility, DetailsListLayoutMode, CommandBarButton, getTheme, SelectionMode} from 'office-ui-fabric-react';
import PropTypes from 'prop-types';
import React, {useCallback, useLayoutEffect, useMemo, useState, useContext} from 'react';
import {dispatchResizeEvent} from '../../utils/utils';
Expand Down Expand Up @@ -151,6 +151,7 @@ export const KeyValueList = ({name, value, onChange, onDuplicate, columnWidth, k
getKey={getKey}
checkboxVisibility={CheckboxVisibility.hidden}
layoutMode={DetailsListLayoutMode.fixedColumns}
selectionMode={SelectionMode.none}
compact
/>
</div>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@ export const DockerSection = ({onValueChange, value}) => {
};

return (
<BasicSection sectionLabel={'Docker'}>
<BasicSection sectionLabel='Docker Image'>
<FormShortSection>
<Dropdown
placeholder='Select a docker image'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,17 +25,16 @@ export const MonacoTextFiled = (props) => {
border: 'solid 1px',
borderColor: palette.neutralTertiary,
paddingTop: spacing.s1,
overflow: 'auto',
}}
completionItems={completionItems}
monacoRef={monacoRef}
monacoProps={{
theme: 'vs',
language: 'plaintext',
options: {
automaticLayout: true,
wordWrap: 'on',
readOnly: false,
theme: 'vs',
defaultEOL: 1,
minimap: {enabled: false},
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
*/

import React from 'react';
import {DetailsList, CheckboxVisibility, Stack, DetailsListLayoutMode} from 'office-ui-fabric-react';
import {DetailsList, CheckboxVisibility, Stack, DetailsListLayoutMode, SelectionMode} from 'office-ui-fabric-react';
import PropTypes from 'prop-types';
import {Hint} from './hint';
import {SidebarCard} from './sidebar-card';
Expand Down Expand Up @@ -63,6 +63,7 @@ export const EnvVar = React.memo(({selected, onSelect}) => (
columns={columns}
checkboxVisibility={CheckboxVisibility.hidden}
layoutMode={DetailsListLayoutMode.fixedColumns}
selectionMode={SelectionMode.none}
compact
/>
</div>
Expand Down