Skip to content
This repository has been archived by the owner on Jun 6, 2024. It is now read-only.

[runtime] fix and improvement #3093

Merged
merged 3 commits into from
Jul 7, 2019
Merged

[runtime] fix and improvement #3093

merged 3 commits into from
Jul 7, 2019

Conversation

mzmssg
Copy link
Member

@mzmssg mzmssg commented Jul 5, 2019

  1. try to kill docker process session instead of only the root process, to avoid exit delay.

  2. docker sigterm handler should exit 143

@mzmssg mzmssg requested review from debuggy, Binyang2014 and abuccts July 5, 2019 09:31
@coveralls
Copy link

coveralls commented Jul 5, 2019

Coverage Status

Coverage remained the same at 51.225% when pulling cf19a0a on zimiao/process_group into 6757ab8 on pai-0.14.y.

@mzmssg mzmssg changed the title [runtime] kill docker process group [runtime] fix and improvement Jul 5, 2019
@mzmssg mzmssg merged commit 3fe5ad0 into pai-0.14.y Jul 7, 2019
@mzmssg mzmssg added the 0.14.0 label Jul 8, 2019
mzmssg added a commit that referenced this pull request Jul 8, 2019
* kill docker process group

* exit 143 in docker sigterm handler

* kill the process with the same sid
@mzmssg mzmssg deleted the zimiao/process_group branch July 8, 2019 08:08
debuggy pushed a commit that referenced this pull request Jul 19, 2019
* kill docker process group

* exit 143 in docker sigterm handler

* kill the process with the same sid
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants