This repository has been archived by the owner on Jun 6, 2024. It is now read-only.
Add Job ssh for kube-runtime. Create ssh key secret in cluster-config #3153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uration Add Job ssh for kube-runtime. Create ssh key secret in cluster-configuration
…uration Add Job ssh for kube-runtime. Create ssh key secret in cluster-configuration
…ft/pai into diawang/pure-k8s-job-ssh
…uration Add Job ssh for kube-runtime. Create ssh key secret in cluster-configuration
…ft/pai into diawang/pure-k8s-job-ssh
abuccts
reviewed
Jul 10, 2019
| touch /root/.ssh/authorized_keys | ||
| chmod 600 /root/.ssh/authorized_keys | ||
|
|
||
| mkdir -p /var/run/sshd |
There was a problem hiding this comment.
Better have this in case the files are not created.
| prepare_ssh | ||
| prepare_job_ssh | ||
| prepare_user_ssh | ||
| start_ssh | ||
| fi | ||
| else | ||
| echo "no sshd binary found" >&2 |
There was a problem hiding this comment.
install openssh server for user if there's no sshd in image?
| { | ||
| name: 'job-ssh-secret-volume', | ||
| readOnly: true, | ||
| mountPath: '/etc/ssh-secret', |
There was a problem hiding this comment.
maybe mount to /usr/local/pai/secrets?
There was a problem hiding this comment.
Changed mountPath to /usr/local/pai/ssh-secret. Although I think user should not use this key elsewhere.
abuccts
approved these changes
Jul 11, 2019
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Job ssh for kube-runtime.
Create ssh key secret in cluster-config