This repository has been archived by the owner on Jun 6, 2024. It is now read-only.
Binyli/home page #3411
Merged
Binyli/home page #3411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunqinzheng
reviewed
Aug 21, 2019
sunqinzheng
reviewed
Aug 21, 2019
sunqinzheng
reviewed
Aug 21, 2019
sunqinzheng
reviewed
Aug 21, 2019
| }); | ||
|
|
||
| return ( | ||
| <Card className={t.ph5} style={{paddingRight: spacing.m, ...style}}> |
There was a problem hiding this comment.
I think we need a horizontal scrollbar if the screen is too small (mobile devices)
P.S. For mobile devices I think we could use a sticky header with an expand/collapse button and show all vc items instead of double scrolbars. But this approach needs extra efforts (implmentation, blocked by admin-lte's responsive breakpoint...), I think we could leave it in backlog and discuss it later.
There was a problem hiding this comment.
Agree, we can create an issue for this
sunqinzheng
approved these changes
Aug 23, 2019
debuggy
approved these changes
Aug 23, 2019
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For admin, show VC utilization
Add alerts notification for admin
