This repository has been archived by the owner on Jun 6, 2024. It is now read-only.
[Deployment] Choose services for different cluster type #3528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Choose services for different cluster type in deployment.
Update cluster type in service.yaml.
wangdian
reviewed
Sep 2, 2019
| @@ -34,12 +34,15 @@ class service_management_delete: | |||
| def __init__(self, kube_config_path=None, service_list=None, **kwargs): | |||
| self.logger = logging.getLogger(__name__) | |||
|
|
|||
| self.cluster_object_model = None | |||
| self.cluster_object_model = service_management_configuration.get_cluster_object_model_from_k8s(kube_config_path) | |||
There was a problem hiding this comment.
Saw same codes several times, use a function in utils to do it?
There was a problem hiding this comment.
just keep the original code and its structure
|
|
||
| self.kube_config_path = kube_config_path | ||
|
|
||
| if service_list is None: | ||
| self.service_list = service_management_configuration.get_service_list() | ||
| cluster_type = "yarn" |
There was a problem hiding this comment.
Better not use default value "yarn" in codes?
There was a problem hiding this comment.
there should be somewhere for a default value if user uses this script to operate on an old version cluster without updating cluster configuration
ydye
approved these changes
Sep 2, 2019
Change the initial cluster type to None.
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Choose services for different cluster type in deployment.