This repository has been archived by the owner on Jun 6, 2024. It is now read-only.
[Rest Server] Change to default k8s scheduler #3599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change to default k8s scheduler.
Change vc condition.
Update virtual cluster api for default scheduler.
Update lint.
yqwang-ms
reviewed
Sep 10, 2019
yqwang-ms
reviewed
Sep 10, 2019
yqwang-ms
reviewed
Sep 10, 2019
Update deployment for k8s default scheduler.
abuccts
commented
Sep 10, 2019
| @@ -28,10 +28,6 @@ router.route('/') | |||
| /** GET /api/v2/virtual-clusters - Return cluster virtual cluster info */ | |||
| .get(controller.list); | |||
|
|
|||
| router.route('/nodeResource') | |||
There was a problem hiding this comment.
also changed api /api/v2/virtual-clusters/nodeResource to /api/v2/virtual-clusters?nodes, in case there's a vc called nodeResource
Rename resource units api.
Update containerId and framework name.
Change this to "app" container? align with k8s: https://kubernetes.io/docs/concepts/workloads/pods/init-containers/ Refers to: src/rest-server/src/models/v2/job/k8s.js:294 in bfa3197. [](commit_id = bfa3197, deletion_comment = False) |
Change container name.
yqwang-ms
approved these changes
Sep 11, 2019
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change to default k8s scheduler.