This repository has been archived by the owner on Jun 6, 2024. It is now read-only.
Storage Rest API, Refine Storage Data and CLI #3754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mydmdm
approved these changes
Oct 20, 2019
| groupsc_parser = subparsers.add_parser("groupsc", description="Manage group storage config", formatter_class=argparse.RawDescriptionHelpFormatter) | ||
| groupsc_subparsers = groupsc_parser.add_subparsers(help="Manage group storage config") | ||
| # ./storagectl.py groupsc add GROUP_NAME STORAGE_CONFIG_NAME | ||
| groupsc_add_parser = groupsc_subparsers.add_parser("add") |
There was a problem hiding this comment.
actually I think ./storagectl.py add-groupsc ... is more clear and easy to read, however, it does not matter
maybe later I will try to merge this script to the SDK if necessary
There was a problem hiding this comment.
Sure. Actually I suggest later, we only manage storage through rest-api because as storage is part of the PAI, we don't need to manage it in two ways.
… config in user info Add CRUD for Storage Set storage configs for group Get user storage config in user info
Create namespace and secret when deploy rest-server
wangdian
force-pushed
the
diawang/storage-crud
branch
from
8b2a592 to
3480e72
Compare
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add CRUD for Storage
Set storage configs for group
Get user storage config in user info
Call Storage Rest Api in webportal
Refine Storage CLI