Skip to content
This repository has been archived by the owner on Jun 6, 2024. It is now read-only.

[Rest Server] Update hived resource validation #3867

Merged
merged 1 commit into from
Nov 19, 2019

Conversation

abuccts
Copy link
Member

@abuccts abuccts commented Nov 19, 2019

Update hived resource validation.

Update hived resource validation.
@abuccts abuccts requested a review from mzmssg November 19, 2019 05:05
@mzmssg
Copy link
Member

mzmssg commented Nov 19, 2019

Maybe we can remove one from memory/memoryMB to uniform the variable name?

@abuccts your opinion?

@mzmssg
Copy link
Member

mzmssg commented Nov 19, 2019

Actually it's the same issue as #3595. A uniform name could resolve the problem.

@abuccts
Copy link
Member Author

abuccts commented Nov 19, 2019

Actually it's the same issue as #3595. A uniform name could resolve the problem.

It's a bug fix instead of uniforming name.
In #3225, the source object only uses memory but reference uses both memory and memoryMB.

@mzmssg
Copy link
Member

mzmssg commented Nov 19, 2019

Yeah, I know it's a bug.
I just suggest to replace all xxMemoryMB with xxMemory, then variable name align with the source.

@abuccts abuccts merged commit 2fb33ed into master Nov 19, 2019
@abuccts abuccts deleted the xiongyf/fix-hived-config branch November 19, 2019 10:39
@hzy46 hzy46 mentioned this pull request Apr 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants