Sym path compat and errors #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 25, 2022 19:53
Errors indicating the symbol path was unexpected were being swallowed.
|
@microsoft-github-policy-service agree [company="default"] |
|
@microsoft-github-policy-service agree |
DrChat
requested changes
Nov 8, 2022
DrChat
approved these changes
Nov 8, 2022
comcma
approved these changes
Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Case mismatch in the symbol server path means
srv*causes pdblister to fail to proceed. There's no reason to fail here, this PR normalizes thesrvcomponents case before checking.This PR also adds clearer error messages around this, and makes anyhow show the cause of failures to download.