Add support for Boolean8 to NetTrace V6.#2318
Merged
brianrob merged 1 commit intomicrosoft:mainfrom Oct 16, 2025
Merged
Conversation
EventSource writes booleans differently in manifest mode vs self-describing mode. Manifest mode uses a 4 byte boolean event field which NetTrace has always supported but Self-describing wrote a 1 byte boolean which NetTrace had no metadata encoding for. Adding support for Boolean8 to NetTrace gives us a path forward to properly describe booleans in metadata regardless of mode.
noahfalk
requested review from
brianrob,
cincuranet,
leculver,
marklio and
mconnew
as code owners
brianrob
approved these changes
Oct 16, 2025
This was referenced Oct 31, 2025
Merged
Closed
This was referenced Nov 12, 2025
This was referenced Jan 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EventSource writes booleans differently in manifest mode vs self-describing mode. Manifest mode uses a 4 byte boolean event field which NetTrace has always supported but Self-describing wrote a 1 byte boolean which NetTrace had no metadata encoding for. Adding support for Boolean8 to NetTrace gives us a path forward to properly describe booleans in metadata regardless of mode.