Skip to content

Special-Case BitMask Parsing #2327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brianrob merged 2 commits into from
Nov 7, 2025
Merged

Special-Case BitMask Parsing #2327

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
19055cb
Special-Case BitMask Parsing
brianrob Nov 6, 2025
e41560b
Address code review feedback.
brianrob Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/TraceEvent/DynamicTraceEventParser.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -529,7 +529,15 @@ private object GetPayloadValueAt(ref PayloadFetch payloadFetch, int offset, int
for (int i = 0; i < arrayCount; i++)
{
object value = GetPayloadValueAt(ref arrayInfo.Element, offset, payloadLength);
if (value.GetType() != elementType)
// Some events have metadata of the form:
// input=Array of ulong
// output=Array of IntPtr
// This is common for bitmasks. To address this, we special case it here.
if (elementType == typeof(IntPtr) && value is ulong uintVal)
{
value = new IntPtr(unchecked((long)uintVal));
}
else if (value.GetType() != elementType)
{
value = ((IConvertible)value).ToType(elementType, null);
}
Expand Down