Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DLR support for TraceEvent dynamic properties #630

Merged
merged 1 commit into from
Jun 13, 2018

Conversation

jazzdelightsme
Copy link
Member

The Dynamic Language Runtime approach won't be as efficient as the
TraceParserGen approach, but it is convenient for prototyping or
accessing event data from PowerShell.

(see the updates to the documentation for a bit more info)

The DLR is supported in .NET Standard 2.0, but not 1.6, so we #if it out
for 1.6.

Addresses #617.

The Dynamic Language Runtime approach won't be as efficient as the
TraceParserGen approach, but it is convenient for prototyping or
accessing event data from PowerShell.

(see the updates to the documentation for a bit more info)

The DLR is supported in .NET Standard 2.0, but not 1.6, so we #if it out
for 1.6.

Addresses microsoft#617.
@jazzdelightsme
Copy link
Member Author

Check it out, @heaths.

Copy link
Member

@heaths heaths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@jazzdelightsme
Copy link
Member Author

Looking for a quick way to bring down the count of open Pull Requests? This one is a small, surgical change, complete with appropriate doc and test changes--complete this one for an easy win! :D

@vancem
Copy link
Contributor

vancem commented Jun 13, 2018

I agree completely uncontroversial. Sorry for the delay and thanks for doing this.

@vancem vancem merged commit 9e1ea08 into microsoft:master Jun 13, 2018
@jazzdelightsme jazzdelightsme deleted the user/danthom/traceEventDlr branch June 13, 2018 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants