Fix dev-time load failure loading KernelTraceControl. #745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OSExtentions needs to be 'next' to the architecture directories where KernelTraceControl.dll lives for it to load them properly. This works for published .NET Core apps, but by default 'dotnet run' runs nuget DLLs out of the nuget cache (it does not copy them to the app directory). This breaks the loading of KernelTraceControl.dll. We already manually copy the native files and some interop files to the output directory in the TraceEvent nuget package. Here we simply add OSExtentions.dll to that list so it is loaded from the same place even in the dev-time scenario.
|
@adamsitnik - this is my counter-proposal for fixing the issue you ran into. Basically it is you option 2 (fighting with nuget to get the DLL in the right place). It just so happens, we had done this fighting in the past, so it was pretty easy to add this. It is also the least hacky way to solve the problem (TraceEvent code should not know about Nuget packaging conventions). |
|
@adamsitnik you can try this out yourself, but I was able to reproduce your failure, and this fixed it. |
|
@vancem thanks a lot! I have verified it and the fix solves the problem. And I have learned new NuGet trick from this PR ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OSExtentions needs to be 'next' to the architecture directories where KernelTraceControl.dll lives for it to load
them properly. This works for published .NET Core apps, but by default 'dotnet run' runs nuget DLLs out of
the nuget cache (it does not copy them to the app directory). This breaks the loading of KernelTraceControl.dll.
We already manually copy the native files and some interop files to the output directory in the TraceEvent nuget
package. Here we simply add OSExtentions.dll to that list so it is loaded from the same place even in the dev-time
scenario.