Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dll naming for linux #781

Merged
merged 1 commit into from
Nov 11, 2018

Conversation

gleocadie
Copy link
Contributor

We have a project that references TraceEvent Nuget package. When building that project, MSBuild generates the deps.json file for the executable and will copy/paste all TraceEvent dependencies in the output dir.
The deps.json will contain the original name of all assemblies needed to launch the executable.
The Microsoft.Diagnostics.Tracing.TraceEvent.props file instructs to copy OSExtensions.dll (original name) to the output directory and rename it to OsExtensions.dll.

When running the project on Linux, it won't start because it won't be able to find the OSExtensions.dll, because it has been renamed to OsExtensions.dll.

@vancem
Copy link
Contributor

vancem commented Nov 11, 2018

Thanks for fixing this. Checking this in.
There is likely to be something that forces an update to nuget.org in the week or two. If you need an official build of TraceEvent before that let me know and I will see what I can do to expedite it.

@vancem vancem merged commit 2e8a74a into microsoft:master Nov 11, 2018
@gleocadie
Copy link
Contributor Author

Hello @vancem , thanks for taking my PR.
About the NuGet, we can wait for the release of the next release. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants