Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Style check for all platforms #443

Merged
merged 15 commits into from
Jul 21, 2023
Merged

Style check for all platforms #443

merged 15 commits into from
Jul 21, 2023

Conversation

nasc17
Copy link
Collaborator

@nasc17 nasc17 commented Jul 18, 2023

No description provided.

@nasc17 nasc17 added the Release-0.5 Included in PG Extension 0.5.0 label Jul 18, 2023
@nasc17 nasc17 requested a review from a team as a code owner July 18, 2023 22:17
@nasc17
Copy link
Collaborator Author

nasc17 commented Jul 20, 2023

@DaeunYim now fails pipeline for failed tests

@DaeunYim
Copy link
Contributor

Oh I think you'll need to run

git commit --allow-empty -m "trigger CI" and push this to run the pipeline again. The test fix was merged some time back and I think this is failing due to that

@nasc17 nasc17 merged commit 4bec18e into master Jul 21, 2023
nasc17 added a commit that referenced this pull request Aug 1, 2023
@nasc17 @pradeepkintali
@microsoft-github-policy-service @jonels-msft @DaeunYim @samir-puranik
Snap v1.9.0 (#451)
98d2f00 
* Create build_pullrequest.yml (#415)

* Update build_pullrequest.yml

* Update build_pullrequest.yml (#416)

* Update build_pullrequest.yml

* Rename config.json.txt to config.json

* Update build_pullrequest.yml

to run ps1 script tests only for Windows.

* Update build_pullrequest.yml

* Update build_pullrequest.yml

* Create yml file for release build and updates, including unit tests for Windows (#417)

* add non windows tests

* include release

* add display name for bash

* fix extra '

* build fix

* fix windows tests and take out linux

* powershell 2

* add back in conditions

* fix password

* fix test path

* spacing and test file

* remove style check

* fix  build

* Update table routes (#414)

* Function order

* format

* updating names

* update routes

* spacing and order

* fix system folders

* spacing

* remove unnecessary system folders

* release trigger (#418)

* Microsoft mandatory file (#419)

Co-authored-by: microsoft-github-policy-service[bot] <77245923+microsoft-github-policy-service[bot]@users.noreply.github.com>
Co-authored-by: nasc17 <69922333+nasc17@users.noreply.github.com>

* Update build pipelines for including Linux. (#420)

* include linux

* include style check

* style fixes and build fix

* styling

* styling

* update build file names

* Fix display of partitioned tables (#422)

* Include partitioned tables in catalog queries
* Exclude partitions themselves from table list view

* Have Insiders build publish to Pre-Release on Github (#425)

* publish to github

* syntax

* Psycopg version bump 2 to 3 (#428)

* Fix broken language service

* Fixing tests

* remove qt literals

* Fix test codes

* Fix psycopg2 code

* autopep

* test debugger

* Fix psycopg2 references

* Add support for showing stored procedures (#423)

* init routing updates

* procedure templates

* spacing

* script fixes

* remove qtLiteral condition from sql files

* fix quotation issue

---------

Co-authored-by: Daeun Yim <daeunyim@microsoft.com>

* Use service connection for publishing insiders build (#426)

* publish to github

* syntax

* user service connection

* add userSpecifiedTag

* new service connection

* more permissions

* add jobs

* spacing

* fix jobs

* task name fix

* update condition

* lint change

* spacing for powershell

* powershell inlinescript

* Update powershell again

* continue on error for deleting pre-release

* Remove deleting builds and add build number

* use workspace

* download build artififacts

* use System.ArtifactsDirectory for release

* include vmImage

* download in second job

* fix spacing

* github for release build

* changelogtype

* Use insiders tag, delete old pre-release

* add code sign to PR build and lint fixes

* Dynamically set versioning for apple silicon artifacts (#429)

* Fix broken language service

* use variable for vsts artifact versioning

* use variable for vsts artifact versioning

* use package name as a variable too

* Update common.py

* trigger ci

* fix (#433)

* Add pg_dump and pg_restore for linux postgresql 14 (#436)

* Included pg_dump and pg_restore for 14  linux

* include bin

* fix file

* Include partitioned tables, hide partitions (#434)

* Filter table partitions from database "Manage" screen
* Include partitioned tables/columns in completion popup

* Fix change log for insiders' releases (#437)

* change based on last insiders

* variable

* Addressing Save As issues from queries (#438)

* add delimiter

* check for exception

* display raw object sending to excel

* add line terminator

* add delimiter test

* fix failing tests

* fix assert

* fix assert

* Fix edit data revert row issue (#439)

* Fix broken language service

* fix edit data revert logic

* Update common.py

* Update common.py

* Fixing CREATE script for Functions (#442)

Fixes create script for functions such that:

- Syntax is correct for immediate execution
- Function body is included for all versions (< 14 and >= 14)
- Should work for procedures and functions

Some template files needed to be changed slightly to prevent using the full properties that are generated for functions in pgAdmin.

* Optimize pgtoolsservice size (#441)

* Fix broken language service

* Reduce executable size and only download host related pg executables

* Update common.py

why is this keep coming back..

* Fix failing edit data test (#444)

* Fix broken language service

* fix test

* Revert "Fix broken language service"

This reverts commit f8ab759.

* style fix

* Fix dsn parameters parsing to handle username with spaces (#446)

* Fix broken language service

* Revert "Fix broken language service"

This reverts commit f8ab759.

* Handle role name containing spaces

* fix style issue

* Style check for all platforms (#443)

* style check all platforms

* remove warningpreference from bash

* upgrade pip and try mac tests

* python3 install pip

* update calls

* remove pg start and fix style check

* add fail on test

* remove continue on error

* remove failOnStderr

* fail check

* Revert "fail check"

This reverts commit c50e269.

* Psycopg3 Transactions update (#448)

* init

* notification handler

* include save point

* build and test issues

* fix status

* fix for setting back autocommit

* fix trans error check

* add transaction messaging

* fix open block

* fix text format

* test fix

* test

* update messages

* test message

* starts with begin

* Fix session id connection error (#449)

* Fix broken language service

* fix session id failure

* remove unnecessary logging

* fix not ready error and test

* Fixing the Scripting issues for Indexes (#450)

* initial commit

* started to fix style check and tests

* check to see if parent hasattr of schema

* is_sort_nulls_applicable should always be set to true

* fix (#452)

* Allowing table objects to be expanded again (#453)

This fix enables table objects to be expanded again. We take the schema value from the table object's parent node instead of the node itself.

* use psycopg function for parsing (#456)

---------

Co-authored-by: Pradeep Kintali <50682039+pradeepkintali@users.noreply.github.com>
Co-authored-by: microsoft-github-policy-service[bot] <77245923+microsoft-github-policy-service[bot]@users.noreply.github.com>
Co-authored-by: Joe Nelson <48225118+jonels-msft@users.noreply.github.com>
Co-authored-by: Daeun Yim <69321306+DaeunYim@users.noreply.github.com>
Co-authored-by: Daeun Yim <daeunyim@microsoft.com>
Co-authored-by: samir-puranik <35553548+samir-puranik@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaeunYim DaeunYim DaeunYim approved these changes

Assignees
No one assigned
Labels
Release-0.5 Included in PG Extension 0.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nasc17 @DaeunYim