Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update nuget dependencies in .Tests and ..TestingHarnessTest #2557

Closed
2 tasks done
maw136 opened this issue Apr 19, 2023 · 3 comments
Closed
2 tasks done

chore: update nuget dependencies in .Tests and ..TestingHarnessTest #2557

maw136 opened this issue Apr 19, 2023 · 3 comments

Comments

@maw136
Copy link
Contributor

maw136 commented Apr 19, 2023 •
edited
Loading

Chore, update nugets in Tests and TestHarness.
Should have no impact on main dependencies of generated nugets.

fix: #2556

Tasks
Beta Give feedback
  1. chore: Rewrite WritableStreamImpl to WritableStreamWrapper and StreamImpl to StreamWrapper #2592
  2. chore: small refinements in prep. for nuget update #2590
@maw136 maw136 changed the title chore: update nuget dependencies chore: update nuget dependencies in .Tests and ..TestingHarnessTest Apr 19, 2023
@maw136
Copy link
Contributor Author

maw136 commented Apr 19, 2023 •
edited
Loading

Added small changes necessitated by failing build/tests after nuget update.

@mxschmitt mxschmitt mentioned this issue May 2, 2023
Closed
@maw136
Copy link
Contributor Author

maw136 commented May 29, 2023

Extracted code changes to separate PRs

@mxschmitt
Copy link
Member

Closing for now since we upgrade packages as we have to instead of regularly in chunks.

@mxschmitt mxschmitt closed this as not planned Won't fix, can't repro, duplicate, stale Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: update nugets in .Tests and .TestingHarnessTest maw136/playwright-dotnet
2 participants
@maw136 @mxschmitt