Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Rewrite WritableStreamImpl to WritableStreamWrapper and StreamImpl to StreamWrapper #2592

Closed
Tracked by #2557
maw136 opened this issue May 29, 2023 · 3 comments
Closed
Tracked by #2557

chore: Rewrite WritableStreamImpl to WritableStreamWrapper and StreamImpl to StreamWrapper #2592

maw136 opened this issue May 29, 2023 · 3 comments

Comments

@maw136
Copy link
Contributor

maw136 commented May 29, 2023

chore: Rewrite WritableStreamImpl to WritableStreamWrapper and StreamImpl to StreamWrapper keeping best practices and notes for implementers in mind:�https://learn.microsoft.com/en-us/dotnet/api/system.io.stream?f1url=%3FappId%3DDev16IDEF1%26l%3DEN-US%26k%3Dk(System.IO.Stream)%3Bk(DevLang-csharp)%26rd%3Dtrue&view=net-6.0
This was referenced May 29, 2023
Closed
Closed
@maw136
Copy link
Contributor Author

maw136 commented May 29, 2023

Solved by #2593

@mxschmitt
Copy link
Member

Closing as per #2593 (comment).

@mxschmitt mxschmitt closed this as not planned Won't fix, can't repro, duplicate, stale Jun 27, 2023
@maw136
Copy link
Contributor Author

maw136 commented Jun 29, 2023 •
edited
Loading

This detects issues with current code:
https://github.com/microsoft/playwright-dotnet/actions/runs/5414490141/jobs/9841624728?pr=2556
so the rewrite is actually desirable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@maw136 @mxschmitt