feat(cors): Add CORS policy check and response to browsers. #450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AOrazaev
commented
May 20, 2025
AOrazaev
commented
May 20, 2025
AOrazaev
commented
May 20, 2025
AOrazaev
commented
May 20, 2025
|
@microsoft-github-policy-service agree |
AOrazaev
force-pushed
the
orazaev/cors_support
branch
from
b21f59d to
770eae1
Compare
src/program.ts
Outdated
| @@ -34,6 +34,7 @@ program | |||
| .option('--caps <caps>', 'comma-separated list of capabilities to enable, possible values: tabs, pdf, history, wait, files, install. Default is all.') | |||
| .option('--cdp-endpoint <endpoint>', 'CDP endpoint to connect to.') | |||
| .option('--config <path>', 'path to the configuration file.') | |||
| .option('--cors-allow-origins <origin>', 'semicolon-separated list of allowed origins by CORS policy. Can be regex.', semicolonSeparatedList) | |||
There was a problem hiding this comment.
It'd be nice if origins syntax was consistent (blocked, allowed, cors). Let's not support regex here.
There was a problem hiding this comment.
Great, let me make the changes.
There was a problem hiding this comment.
Done:
- Renamed to
--cors-allowed-origins. - Replaced regex check with equality check.
added 9 commits
May 28, 2025 15:34
Do strict string check instead of regex.
AOrazaev
force-pushed
the
orazaev/cors_support
branch
from
bfe66d6 to
9eeab1e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.