-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Add fullPage mode to browser_take_screenshot #704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -28,11 +28,17 @@ const screenshotSchema = z.object({ | |||||
| filename: z.string().optional().describe('File name to save the screenshot to. Defaults to `page-{timestamp}.{png|jpeg}` if not specified.'), | ||||||
| element: z.string().optional().describe('Human-readable element description used to obtain permission to screenshot the element. If not provided, the screenshot will be taken of viewport. If element is provided, ref must be provided too.'), | ||||||
| ref: z.string().optional().describe('Exact target element reference from the page snapshot. If not provided, the screenshot will be taken of viewport. If ref is provided, element must be provided too.'), | ||||||
| fullPage: z.boolean().optional().describe('When true, takes a screenshot of the full scrollable page, instead of the currently visible viewport. Cannot be used with element screenshots.'), | ||||||
| }).refine(data => { | ||||||
| return !!data.element === !!data.ref; | ||||||
| }, { | ||||||
| message: 'Both element and ref must be provided or neither.', | ||||||
| path: ['ref', 'element'] | ||||||
| }).refine(data => { | ||||||
| return !(data.fullPage && (data.element || data.ref)); | ||||||
| }, { | ||||||
| message: 'fullPage cannot be used with element screenshots.', | ||||||
| path: ['fullPage'] | ||||||
| }); | ||||||
|
|
||||||
| const screenshot = defineTool({ | ||||||
|
|
@@ -50,11 +56,18 @@ const screenshot = defineTool({ | |||||
| const snapshot = tab.snapshotOrDie(); | ||||||
| const fileType = params.raw ? 'png' : 'jpeg'; | ||||||
| const fileName = await outputFile(context.config, params.filename ?? `page-${new Date().toISOString()}.${fileType}`); | ||||||
| const options: playwright.PageScreenshotOptions = { type: fileType, quality: fileType === 'png' ? undefined : 50, scale: 'css', path: fileName }; | ||||||
| const options: playwright.PageScreenshotOptions = { | ||||||
| type: fileType, | ||||||
| quality: fileType === 'png' ? undefined : 50, | ||||||
| scale: 'css', | ||||||
| path: fileName, | ||||||
| ...(params.fullPage !== undefined && { fullPage: params.fullPage }) | ||||||
|
||||||
| ...(params.fullPage !== undefined && { fullPage: params.fullPage }) | |
| fullPage: params.fullPage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even when I pass fullPage, the message below will say // Screenshot viewport.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in ffbc94f. The screenshot message now correctly shows "full page" when fullPage is true instead of always showing "viewport".