Skip to content

Commit

Permalink
fix: #518 Update RECORD file during wheel creation (#525)
Browse files Browse the repository at this point in the history
  • Loading branch information
kumaraditya303 authored Mar 3, 2021
1 parent 790d4f0 commit fb2dfcf
Show file tree
Hide file tree
Showing 4 changed files with 32 additions and 18 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
- name: Install browsers
run: python -m playwright install
- name: Lint
run: pre-commit run --all-files
uses: pre-commit/action@v2.0.0
- name: Generate APIs
run: bash scripts/update_api.sh
- name: Verify API is up to date
Expand Down
8 changes: 4 additions & 4 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# See https://pre-commit.com/hooks.html for more hooks
repos:
- repo: https://github.com/pre-commit/pre-commit-hooks
rev: v3.2.0
rev: v3.4.0
hooks:
- id: trailing-whitespace
- id: end-of-file-fixer
Expand All @@ -13,14 +13,14 @@ repos:
hooks:
- id: black
- repo: https://github.com/pre-commit/mirrors-mypy
rev: v0.782
rev: v0.812
hooks:
- id: mypy
- repo: https://gitlab.com/pycqa/flake8
rev: '3.8.3'
rev: 3.8.4
hooks:
- id: flake8
- repo: https://github.com/pycqa/isort
rev: 5.5.4
rev: 5.7.0
hooks:
- id: isort
27 changes: 14 additions & 13 deletions local-requirements.txt
Original file line number Diff line number Diff line change
@@ -1,23 +1,24 @@
autobahn==20.7.1
pytest==6.1.0
autobahn==21.2.2
pytest==6.2.2
pytest-asyncio==0.14.0
pytest-cov==2.10.1
pytest-cov==2.11.1
pytest-sugar==0.9.4
pytest-xdist==2.1.0
pytest-xdist==2.2.1
pytest-timeout==1.4.2
flaky==3.7.0
pixelmatch==0.2.1
Pillow==8.0.0
mypy==0.782
setuptools==50.3.0
pixelmatch==0.2.3
Pillow==8.1.0
mypy==0.812
setuptools==54.0.0
# TODO: use PyPi version after >20.3.0 is released
git+https://github.com/twisted/twisted.git@4ff22287cab3b54f51cee41ea2619e72d1bff2e4
wheel==0.35.1
wheel==0.36.2
auditwheel==3.3.1
black==20.8b1
pre-commit==2.7.1
flake8==3.8.3
twine==3.2.0
pyOpenSSL==19.1.0
pre-commit==2.10.1
flake8==3.8.4
twine==3.3.0
pyOpenSSL==20.0.1
service_identity==18.1.0
pandas==1.2.2
objgraph==3.5.0
13 changes: 13 additions & 0 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
from pathlib import Path

import setuptools
from auditwheel.wheeltools import InWheel
from wheel.bdist_wheel import bdist_wheel as BDistWheelCommand

driver_version = "1.9.0-1614037901000"
Expand Down Expand Up @@ -96,6 +97,18 @@ def run(self) -> None:
zip.writestr("playwright/driver/README.md", "Universal Mac package")

os.remove(base_wheel_location)
for whlfile in glob.glob("dist/*.whl"):

os.makedirs("wheelhouse", exist_ok=True)
with InWheel(
in_wheel=whlfile,
out_wheel=os.path.join("wheelhouse", os.path.basename(whlfile)),
ret_self=True,
):
print("Updating RECORD file of %s" % whlfile)
shutil.rmtree("dist")
print("Copying new wheels")
shutil.move("wheelhouse", "dist")


setuptools.setup(
Expand Down

0 comments on commit fb2dfcf

Please sign in to comment.