Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Don't use implicit-optional for type hints #1460

Closed
KotlinIsland opened this issue Jul 28, 2022 · 4 comments · Fixed by #1475
Closed

[BUG] Don't use implicit-optional for type hints #1460

KotlinIsland opened this issue Jul 28, 2022 · 4 comments · Fixed by #1475
Assignees

Comments

@KotlinIsland
Copy link

KotlinIsland commented Jul 28, 2022

Context:

  • Playwright Version: [what Playwright version do you use?] 1.24.0
  • Operating System: [e.g. Windows, Linux or Mac] N/A
  • Python version: [e.g. 3.7, 3.9] 3.10
  • Browser: [e.g. All, Chromium, Firefox, WebKit] N/A
  • Extra: [any specific details about your environment] N/A

Code Snippet

browser.launch(proxy=None)  # mypy error: expected "ProxySettings" found "None"

Describe the bug

proxy: ProxySettings = None,

This should be typed as:

proxy: Optional[ProxySettings] = None,

implicit optional is deprecated(dead in the water 💀🌊)

@rwoll rwoll changed the title [BUG] (🐞) Don't use implicit-optional for type hints [BUG] Don't use implicit-optional for type hints Jul 28, 2022
@rwoll
Copy link
Member

rwoll commented Jul 28, 2022

Reference: python/mypy#9091

@rwoll rwoll added the v1.26 label Jul 28, 2022
@KotlinIsland
Copy link
Author

@rwoll are emojis deprecated?

@rwoll
Copy link
Member

rwoll commented Jul 28, 2022

In titles, yes. The title was standardized with the rest of the titles. The emoji is redundant to the [BUG] bit.

Thanks!

@KotlinIsland
Copy link
Author

I like the emojis, every time I see them it puts a smile on my dial 😄

@rwoll rwoll added v1.25 and removed v1.26 labels Aug 1, 2022
@rwoll rwoll self-assigned this Aug 1, 2022
rwoll added a commit to rwoll/playwright-python that referenced this issue Aug 1, 2022
rwoll added a commit to rwoll/playwright-python that referenced this issue Aug 1, 2022
rwoll added a commit that referenced this issue Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants