[BUG] Failing step is not highlighted in red in actions panel for versions after 1.39.0

[jfp1992]

System info

• Playwright Version: [v1.40.0, 1.41.0]
• Operating System: [Windows 11]
• Browser: [Chromium]
• Other info:

Steps

• Run a failing pytest test
• Open trace

Expected

Failing step in the actions panel should be highlighted in red

Actual

Failing step not highlighted in red

Additional info
This is working on version 1.39.0

All traces opened in trace.playwright.dev

[mxschmitt]

Can you provide us a introductions on how to reproduce this? This would help us a ton in order to triage and prioritise this!

[jfp1992]

create a new project with the latest playwright:
pip install playwright
pip install pytest
pip install pytest-playwright

main.py:

from playwright.sync_api import Page, expect


def test_red_step(page: Page):
    page.goto("https://playwright.dev")
    expect(page.locator("body")).to_be_hidden()

pytest.ini:

[pytest]
addopts =
    --headed
    --tracing retain-on-failure

run the test with playwright 1.39.0: red assertion step
run the test with playwright 1.40.0: white assertion step
run the test with playwright 1.41.0: white assertion step

[mxschmitt]

I can reproduce:

1.39.0: good
1.40.0: bad

Caused by microsoft/playwright#28112.

This also affects Node.js without the test-runner, Playwright for Java, and probably .NET.

import { chromium, expect } from '@playwright/test';
(async () => {
  const browser = await chromium.launch();
  const context = await browser.newContext();
  try {
    await context.tracing.start({ screenshots: true, snapshots: true });
    const page = await context.newPage();
    await page.goto('https://example.com');
    await expect(page).toHaveTitle('123');
  } finally {
    await context.tracing.stop({ path: 'trace.zip' });
  }
  await context.close();
  await browser.close();
})();

Expected: Last step is red.
Actual: Its not red.

It also does not show the expect matcher name correctly:

[HermanBide]

has this issue been fixed yet ? if not can i contribute ?

[mxschmitt]

This should be fixed in https://github.com/microsoft/playwright-python/releases/tag/v1.41.2.

[HermanBide]

I am looking for issues or bugs to fix. i would like to contribute

…

On Fri, Feb 9, 2024 at 11:16 AM Max Schmitt ***@***.***> wrote: Closed #2258 <#2258> as completed. — Reply to this email directly, view it on GitHub <#2258 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AVM3FTMAXEAUOWXYLOJFPDLYSZYXXAVCNFSM6AAAAABCINM57GVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJRG43DCNRRGU2TGOA> . You are receiving this because you commented.Message ID: ***@***.*** com>