Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cdp): expose cdp session #133

Merged
merged 1 commit into from
Aug 3, 2020
Merged

Conversation

pavelfeldman
Copy link
Member

  • driver-by: all optional arguments in the API should be = None, not = defaultValue.

@coveralls
Copy link

coveralls commented Aug 3, 2020

Pull Request Test Coverage Report for Build 192702471

  • 105 of 119 (88.24%) changed or added relevant lines in 9 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 88.646%

Changes Missing Coverage Covered Lines Changed/Added Lines %
playwright/object_factory.py 12 13 92.31%
playwright/selectors.py 6 7 85.71%
playwright/async_api.py 19 21 90.48%
playwright/chromium_browser_context.py 23 27 85.19%
playwright/sync_api.py 15 21 71.43%
Totals Coverage Status
Change from base Build 192672313: 0.003%
Covered Lines: 3482
Relevant Lines: 3928

💛 - Coveralls

@pavelfeldman pavelfeldman merged commit 359f8cc into microsoft:master Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants