Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: validate dictionary keys #137

Merged
merged 1 commit into from
Aug 4, 2020

Conversation

pavelfeldman
Copy link
Member

No description provided.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 194383153

  • 167 of 174 (95.98%) changed or added relevant lines in 14 files are covered.
  • 16 unchanged lines in 7 files lost coverage.
  • Overall coverage decreased (-0.1%) to 88.776%

Changes Missing Coverage Covered Lines Changed/Added Lines %
playwright/browser_type.py 12 19 63.16%
Files with Coverage Reduction New Missed Lines %
playwright/browser_type.py 1 65.38%
playwright/object_factory.py 1 98.53%
playwright/async_api.py 2 90.6%
playwright/connection.py 2 97.02%
playwright/sync_api.py 2 67.81%
playwright/sync_base.py 3 93.33%
playwright/main.py 5 82.19%
Totals Coverage Status
Change from base Build 194173457: -0.1%
Covered Lines: 3575
Relevant Lines: 4027

💛 - Coveralls

@coveralls
Copy link

coveralls commented Aug 4, 2020

Pull Request Test Coverage Report for Build 195303243

  • 177 of 183 (96.72%) changed or added relevant lines in 14 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.1%) to 89.604%

Changes Missing Coverage Covered Lines Changed/Added Lines %
scripts/documentation_provider.py 105 106 99.06%
playwright/browser_type.py 14 19 73.68%
Files with Coverage Reduction New Missed Lines %
playwright/browser_type.py 1 74.07%
playwright/connection.py 1 97.62%
Totals Coverage Status
Change from base Build 195249552: 0.1%
Covered Lines: 3620
Relevant Lines: 4040

💛 - Coveralls

Copy link
Member

@mxschmitt mxschmitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work!

@pavelfeldman pavelfeldman force-pushed the better_types branch 4 times, most recently from 0c3a29d to aa44ace Compare August 4, 2020 19:49
@pavelfeldman pavelfeldman merged commit e860dd8 into microsoft:master Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants