Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add downstream test discrepancy reporter #167

Merged

Conversation

rwoll
Copy link
Member

@rwoll rwoll commented Aug 12, 2020

Example Run and Output:

$ python tests/report_downstream_test_diffs.py --playwright-js-path=../playwright --api=async

MISSING, MISPELLED, OR MISNAMED:
async/test_accessibility.py::test_autocomplete
…
async/test_workers.py::test_should_have_JSHandles_for_console_logs
async/test_workers.py::test_should_report_console_logs
async/test_workers.py::test_should_report_errors
async/test_workers.py::test_should_report_network_activity
async/test_workers.py::test_should_report_network_activity_on_worker_creation

Missing: 1213, Found: 105

Relates #138.

Example Run and Output:

```
$ python tests/report_downstream_test_diffs.py --playwright-js-path=../playwright --api=async

MISSING, MISPELLED, OR MISNAMED:
async/test_accessibility.py::test_autocomplete
…
async/test_workers.py::test_should_have_JSHandles_for_console_logs
async/test_workers.py::test_should_report_console_logs
async/test_workers.py::test_should_report_errors
async/test_workers.py::test_should_report_network_activity
async/test_workers.py::test_should_report_network_activity_on_worker_creation

Missing: 1213, Found: 105
```

Relates microsoft#138.
@rwoll
Copy link
Member Author

rwoll commented Aug 12, 2020

Don't be alarmed by the high missing count! 🚨 A few file and test renames will get that back up quite a bit!

Copy link
Member

@mxschmitt mxschmitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would move it over to the scripts directory otherwise it looks quite nice.

tests/report_downstream_test_diffs.py Outdated Show resolved Hide resolved
tests/report_downstream_test_diffs.py Outdated Show resolved Hide resolved
Also update normalization to be friendlier: keep digits, compress
underscores, and strip trailing underscores.
Copy link
Member

@mxschmitt mxschmitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, cool!

scripts/report_downstream_test_diffs.py Show resolved Hide resolved
@rwoll
Copy link
Member Author

rwoll commented Aug 14, 2020

@mxschmitt The when I use check_call, the script hangs on that line.

@rwoll rwoll force-pushed the feature/add-test-discrepency-tool branch from 02af14a to b50e46c Compare August 14, 2020 18:58
@pavelfeldman pavelfeldman merged commit 1dfff87 into microsoft:master Aug 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants