-
Notifications
You must be signed in to change notification settings - Fork 939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add downstream test discrepancy reporter #167
Add downstream test discrepancy reporter #167
Conversation
Example Run and Output: ``` $ python tests/report_downstream_test_diffs.py --playwright-js-path=../playwright --api=async MISSING, MISPELLED, OR MISNAMED: async/test_accessibility.py::test_autocomplete … async/test_workers.py::test_should_have_JSHandles_for_console_logs async/test_workers.py::test_should_report_console_logs async/test_workers.py::test_should_report_errors async/test_workers.py::test_should_report_network_activity async/test_workers.py::test_should_report_network_activity_on_worker_creation Missing: 1213, Found: 105 ``` Relates microsoft#138.
Don't be alarmed by the high missing count! 🚨 A few file and test renames will get that back up quite a bit! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would move it over to the scripts directory otherwise it looks quite nice.
Also update normalization to be friendlier: keep digits, compress underscores, and strip trailing underscores.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, cool!
@mxschmitt The when I use check_call, the script hangs on that line. |
02af14a
to
b50e46c
Compare
Example Run and Output:
Relates #138.