fix: pass --headed when reusing browser

microsoft · Jan 10, 2023 · 8fd5682 · 8fd5682
1 parent 4d02a9a
commit 8fd5682
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/playwright.config.ts b/playwright.config.ts
@@ -14,9 +14,9 @@
  * limitations under the License.
  */
 import { PlaywrightTestConfig } from '@playwright/test';
-import { TestOptions } from './tests/utils';
+import { WorkerOptions } from './tests/utils';
 
-const config: PlaywrightTestConfig<TestOptions> = {
+const config: PlaywrightTestConfig<WorkerOptions> = {
   testDir: './tests',
   fullyParallel: true,
   forbidOnly: !!process.env.CI,

diff --git a/src/extension.ts b/src/extension.ts
@@ -570,7 +570,7 @@ located next to Run / Debug Tests toolbar buttons.`);
             errorsByFile.set(error.location?.file, error);
           }
         }
-        this._updateDiagnistics(errorsByFile);
+        this._updateDiagnostics(errorsByFile);
         finishedCallback();
       }, 0);
 

diff --git a/src/playwrightTest.ts b/src/playwrightTest.ts
@@ -159,7 +159,9 @@ export class PlaywrightTest {
       '--repeat-each', '1',
       '--retries', '0',
     ];
-    if (this._isUnderTest || this._reusedBrowser.browserServerEnv(false) || args.includes('--headed'))
+    if (this._reusedBrowser.browserServerEnv(false) && !allArgs.includes('--headed') && !this._isUnderTest)
+      allArgs.push('--headed');
+    if (this._isUnderTest || args.includes('--headed'))
       allArgs.push('--workers', '1');
     // Disable original reporters when listing files.
     if (mode === 'list')