Skip to content

Commit

Permalink
test: roll test runner to 0.9.20 (#4062)
Browse files Browse the repository at this point in the history
  • Loading branch information
pavelfeldman authored Oct 6, 2020
1 parent 2df6425 commit 0db09f8
Show file tree
Hide file tree
Showing 21 changed files with 481 additions and 517 deletions.
166 changes: 77 additions & 89 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,8 @@
"ws": "^7.3.1"
},
"devDependencies": {
"@playwright/test": "^0.9.7",
"@playwright/test-runner": "^0.9.17",
"@playwright/test": "0.9.9",
"@playwright/test-runner": "0.9.20",
"@types/debug": "^4.1.5",
"@types/extract-zip": "^1.6.2",
"@types/mime": "^2.0.3",
Expand Down
6 changes: 4 additions & 2 deletions test/browsertype-connect.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -234,9 +234,11 @@ describe('connect', (suite, { wire }) => {
await page.close();
});

it('should save videos from remote browser', async ({browserType, remoteServer, testOutputPath}) => {
it('should save videos from remote browser', (test, {browserName, platform}) => {
test.flaky(browserName === 'firefox' && platform === 'win32');
}, async ({browserType, remoteServer, testInfo}) => {
const remote = await browserType.connect({ wsEndpoint: remoteServer.wsEndpoint() });
const videosPath = testOutputPath();
const videosPath = testInfo.outputPath();
const context = await remote.newContext({
videosPath,
videoSize: { width: 320, height: 240 },
Expand Down
19 changes: 10 additions & 9 deletions test/channels.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,15 +23,16 @@ type DomainFixtures = {
domain: any;
};

const fixtures = baseFixtures.declareWorkerFixtures<DomainFixtures>();
fixtures.defineWorkerFixture('domain', async ({ }, test) => {
const local = domain.create();
local.run(() => { });
let err;
local.on('error', e => err = e);
await test(null);
if (err)
throw err;
const fixtures = baseFixtures.defineWorkerFixtures<DomainFixtures>({
domain: async ({ }, test) => {
const local = domain.create();
local.run(() => { });
let err;
local.on('error', e => err = e);
await test(null);
if (err)
throw err;
}
});

const { it, expect } = fixtures;
Expand Down
Loading

0 comments on commit 0db09f8

Please sign in to comment.