fix(firefox): fix reload with hash URLs (#21322)

Fixes #21145
microsoft · Mar 2, 2023 · bfc8957 · bfc8957
1 parent e64d0ae
commit bfc8957
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 3 deletions.
diff --git a/packages/playwright-core/src/server/firefox/ffPage.ts b/packages/playwright-core/src/server/firefox/ffPage.ts
@@ -393,7 +393,20 @@ export class FFPage implements PageDelegate {
   }
 
   async reload(): Promise<void> {
-    await this._session.send('Page.reload');
+    const mainFrame = this._page._frameManager.mainFrame();
+    // This is a workaround for https://github.com/microsoft/playwright/issues/21145
+    let hash = '';
+    try {
+      hash = (new URL(mainFrame.url())).hash;
+    } catch (e) {
+      // Ignore URL parsing error, if any.
+    }
+    if (hash.length) {
+      const context = await mainFrame._utilityContext();
+      await context.rawEvaluateJSON(`void window.location.reload();`);
+    } else {
+      await this._session.send('Page.reload');
+    }
   }
 
   async goBack(): Promise<boolean> {

diff --git a/tests/page/page-history.spec.ts b/tests/page/page-history.spec.ts
@@ -185,9 +185,8 @@ it('page.reload should work with cross-origin redirect', async ({ page, server,
   await expect(page).toHaveURL(server.CROSS_PROCESS_PREFIX + '/title.html');
 });
 
-it('page.reload should work on a page with a hash', async ({ page, server, browserName }) => {
+it('page.reload should work on a page with a hash', async ({ page, server }) => {
   it.info().annotations.push({ type: 'issue', description: 'https://github.com/microsoft/playwright/issues/21145' });
-  it.fixme(browserName === 'firefox');
   await page.goto(server.EMPTY_PAGE + '#hash');
   await page.reload();
   await expect(page).toHaveURL(server.EMPTY_PAGE + '#hash');