Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] NPM proxy configuration is not respected #1184

Closed
aslushnikov opened this issue Mar 2, 2020 · 1 comment · Fixed by #1210
Closed

[BUG] NPM proxy configuration is not respected #1184

aslushnikov opened this issue Mar 2, 2020 · 1 comment · Fixed by #1210

Comments

@aslushnikov
Copy link
Collaborator

This is similar to puppeteer/puppeteer#648

The Puppeteer's solution is not very nice though - we were spoiling the global scope.

This time we try to fix this upstream: https://github.com/Rob--W/proxy-from-env/pull/9
@aslushnikov
Copy link
Collaborator Author

Also, upstream issue: https://github.com/Rob--W/proxy-from-env/issues/8

aslushnikov added a commit to aslushnikov/playwright that referenced this issue Mar 4, 2020
@aslushnikov
chore: bump proxy-from-env dependency
82f40f2 
Fixes microsoft#1184
@aslushnikov aslushnikov mentioned this issue Mar 4, 2020
Merged
aslushnikov added a commit that referenced this issue Mar 4, 2020
@aslushnikov
chore: bump proxy-from-env dependency (#1210)
14a7d1c 
Fixes #1184
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: bump proxy-from-env dependency aslushnikov/playwright
1 participant
@aslushnikov