[Bug] Memory leak when evaluating

[hanfeige]

Context:

Playwright Version: 1.27.2
Operating System: Windows
.NET version: .NET 6
Browser: Chrome v 110.0.5481.100
browserArgs："--start-maximized", "--disable-site-isolation-trials", "--disable-blink-features", "--disable-blink-features=AutomationControlled"

After running for about 15-20 minutes

c# code：
var roundsElem = (await gameFrame.EvaluateAsync(@"() => { return e_getRounds();}")).Value;
js code：
function e_getRounds() { return PlazaManager.getInstance().videosMaps.table; }
Injected code：
await frame.AddScriptTagAsync(new FrameAddScriptTagOptions { Content = ClientConsts.gameRPCScript });

The page is in the iframe, and the js code is injected by listening to the FrameNavigated event of the iframe. Everything is fine without calling ifame.EvaluateAsync, which is enabled every 3 seconds, increases the node memory footprint until a memory leak occurs.
Also tried using 1.28.0/1.29.0/1.30.0 and had the same problem.
How do I fix it?

[hanfeige]

Context:

Playwright Version: 1.27.2 Operating System: Windows .NET version: .NET 6 Browser: Chrome v 110.0.5481.100 browserArgs："--start-maximized", "--disable-site-isolation-trials", "--disable-blink-features", "--disable-blink-features=AutomationControlled"

After running for about 15-20 minutes

c# code： var roundsElem = (await gameFrame.EvaluateAsync(@"() => { return e_getRounds();}")).Value; js code： function e_getRounds() { return PlazaManager.getInstance().videosMaps.table; } Injected code： await frame.AddScriptTagAsync(new FrameAddScriptTagOptions { Content = ClientConsts.gameRPCScript });

The page is in the iframe, and the js code is injected by listening to the FrameNavigated event of the iframe. Everything is fine without calling ifame.EvaluateAsync, which is enabled every 3 seconds, increases the node memory footprint until a memory leak occurs. Also tried using 1.28.0/1.29.0/1.30.0 and had the same problem. How do I fix it?

[hanfeige]

Context:
Playwright Version: 1.27.2 Operating System: Windows .NET version: .NET 6 Browser: Chrome v 110.0.5481.100 browserArgs："--start-maximized", "--disable-site-isolation-trials", "--disable-blink-features", "--disable-blink-features=AutomationControlled"
After running for about 15-20 minutes

c# code： var roundsElem = (await gameFrame.EvaluateAsync(@"() => { return e_getRounds();}")).Value; js code： function e_getRounds() { return PlazaManager.getInstance().videosMaps.table; } Injected code： await frame.AddScriptTagAsync(new FrameAddScriptTagOptions { Content = ClientConsts.gameRPCScript });
The page is in the iframe, and the js code is injected by listening to the FrameNavigated event of the iframe. Everything is fine without calling ifame.EvaluateAsync, which is enabled every 3 seconds, increases the node memory footprint until a memory leak occurs. Also tried using 1.28.0/1.29.0/1.30.0 and had the same problem. How do I fix it?

After testing, I found that if the injection function method is not applicable, the amount of memory growth will be greatly reduced. That is, the js function is not injected in advance, but used directly at execution, such as:

Old Code：

frame.AddScriptTagAsync(new FrameAddScriptTagOptions { Content = "function e_getRounds() { return PlazaManager.getInstance().videosMaps.table; }" });
var roundsElem = (await gameFrame.EvaluateAsync(@"() => { return e_getRounds();}")).Value;

New Code
var roundsElem = (await gameFrame.EvaluateAsync(@"() => { return PlazaManager.getInstance().videosMaps.table;}")).Value;

But that still doesn't solve the memory leak problem, and memory continues to grow, from about 15 minutes to about 45 minutes.

[mxschmitt]

Can you provide us a repro which we can run locally?

[hanfeige]

Can you provide us a repro which we can run locally?

After testing, it was found that the causes are as follows: When calling js to obtain the page data, need to minimize the content returned, I will need to return the data by reconstructing the object, only return a few fields, then can greatly reduce the memory, it is not clear what is the cause, tomorrow I upload a test code

[hanfeige]

Can you provide us a repro which we can run locally?

https://github.com/hanfeige/JsStacktrace.git

[mxschmitt]

I was able to track it down to this specific line:

playwright/packages/playwright-core/src/server/javascript.ts

Lines 76 to 81 in 9ca9b08

	_raceAgainstContextDestroyed<T>(promise: Promise<T>): Promise<T> {
	return Promise.race([
	this._destroyedPromise.then(e => { throw e; }),
	promise,
	]);
	}

and this upstream issue: nodejs/node#17469

we'll implement a workaround accordingly.