Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] add Node 20 to CI matrix #22582

Closed
benmccann opened this issue Apr 24, 2023 · 1 comment · Fixed by #22651
Closed

[Bug] add Node 20 to CI matrix #22582

benmccann opened this issue Apr 24, 2023 · 1 comment · Fixed by #22651
Assignees
Labels

Comments

@benmccann
Copy link
Contributor

Node 20 is the latest stable release of Node. As a result, we're trying to add Node 20 to our CI matrix. However, it is causing our Playwright tests to fail in an unexpected and difficult to diagnose manner. I would like if Playwright itself were tested on Node 20 to give me some confidence in whether this might be an issue in Playwright or our own code.

@mxschmitt
Copy link
Member

mxschmitt commented May 11, 2023

Tests which are failing on Node.js 20:

Library:

  • npm run ctest library/browsercontext-storage-state.spec.ts:206 (easy to fix, just a JSON parse error message has changed)

Test Runner:

  • npm run ttest -- esm.spec.ts:146:5

  • npm run ttest -- esm.spec.ts:170:5

  • npm run ttest -- esm.spec.ts:212:5

  • npm run ttest -- esm.spec.ts:369:5

  • npm run ttest -- playwright.reuse.spec.ts:117:5

  • npm run ttest -- playwright.trace.spec.ts:59:5

  • npm run ttest -- playwright.trace.spec.ts:301:5

  • npm run ttest -- watch.spec.ts:60:5

  • npm run ttest -- watch.spec.ts:378:5

  • npm run ttest -- watch.spec.ts:655:5

  • npm run ttest -- esm.spec.ts:146:5 esm.spec.ts:170:5 esm.spec.ts:212:5 esm.spec.ts:369:5 playwright.reuse.spec.ts:117:5 playwright.trace.spec.ts:59:5 playwright.trace.spec.ts:301:5 watch.spec.ts:60:5 watch.spec.ts:378:5 watch.spec.ts:655:5

Upstream diff: nodejs/node@5273947...c94be41
Most likely caused by nodejs/node#44710

This naive patch makes half of the tests work from above, so I believe that the depsCollector is missing and then it should be all working: f7b89a5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants