-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Automatically transform special characters in test name to avoid file overwrite in results folder (e.g. video recording) #23386
Labels
Comments
mxschmitt
added a commit
that referenced
this issue
Jun 27, 2023
mxschmitt
added a commit
that referenced
this issue
Jul 13, 2023
Unfortunately fixing this will break existing users. |
:( Fine, it makes sense. But I think it could be better if this could be mentioned explicitly in the doc so others won't fall into the trap |
Germandrummer92
pushed a commit
to OctoMind-dev/playwright
that referenced
this issue
Oct 27, 2023
…cial chars (microsoft#23414)" (microsoft#24213) This reverts commit 4b1b4dc. microsoft#24184 Reopens microsoft#23386
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Consider the following test
For the first 5 tests, the video recorded for earlier ones will be overwritten by the latest one, since the folder name all resolves to
**-a-b-**
that those special characters got ignored. I don't think it's developer's responsibility to make test namefs.safe
, since it makes sense to use special characters like>
or<
to replacegreater than
orsmaller than
, etc.The text was updated successfully, but these errors were encountered: