Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: missing trace for 2nd browser #31601

Closed
dimkin-eu opened this issue Jul 9, 2024 · 4 comments
Closed

[Bug]: missing trace for 2nd browser #31601

dimkin-eu opened this issue Jul 9, 2024 · 4 comments
Assignees
Labels

Comments

@dimkin-eu
Copy link

Version

1.45.1

Steps to reproduce

test.describe("describe", () => {
    test("short spec", async ({page,browser}) => {
        await page.goto('https://playwright.dev/')
        const page2 = await (await browser.newContext()).newPage()
        await page2.goto('https://github.com/microsoft/playwright')
        await page.locator("bazinga").click()
        await page2.context().close()
    })
})

Expected behavior

  • test fails
  • trace contains all browsers from test

Screenshot 2024-07-09 at 09 49 19

Actual behavior

  • test fails ( this is fine )
  • (it doesn't matter in which browser test fails) trace contains only trace from 'page' fixture

Screenshot 2024-07-09 at 09 49 30

Additional context

1.44.1 was fine, 1.45.1 - fails

use: {
    // headless: false,
    ignoreHTTPSErrors: true,
    screenshot: "off",
    video: "off",
    trace: "on",
    contextOptions: {
        bypassCSP: true,
    },
},

Environment

System:
    OS: macOS 14.5
    CPU: (12) x64 Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
    Memory: 20.10 MB / 32.00 GB
  Binaries:
    Node: 20.13.1 - /usr/local/bin/node
    npm: 10.5.2 - /usr/local/bin/npm
    pnpm: 9.4.0 - /usr/local/bin/pnpm
  Languages:
    Bash: 3.2.57 - /bin/bash
  npmPackages:
    @playwright/test: 1.45.1 => 1.45.1
@dimkin-eu
Copy link
Author

dimkin-eu commented Jul 9, 2024

for sure related to #31541 and #31535

@mxschmitt
Copy link
Member

Looks like already fixed on ToT - @dgozman should we cherry-pick?

@dimkin-eu
Copy link
Author

hmm, there were case which sounds exactly like this , but looks like that tests didn't found ( one more ) regression :(
#23421

@mxschmitt
Copy link
Member

I can verify this is fixed on @beta and should be fixed in v1.45.2 shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants