-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Regression]: Tracefile is missing actions in traceviewer although size of trace and length of recording in metadata suggests complete trace #31535
Comments
We start the trace using this snippet: where browserContext is of type BrowserContext and created as thus: |
We unfortunately need a reproduction in order to triage issues / regressions. We can keep this issue open for a few days - but without a reproduction, we can't act on it. Thanks for your understanding. |
Update: We received similar issues the past 48 hours and it seems like there is a regression. I'll keep it open until the fix is confirmed, but it looks like #31541. |
Retaining traces in the following scenarios: - browser crash; - manual `browser.close()`; - implicit `browser.close()` from the `browser` fixture upon test end. This does not affect the library, where `browser.close()` will not retain the trace and will close the browser as fast as possible. References #31541, #31535, #31537.
Having the same issues, starting from version 1.45.0 probably. It's the same on 1.45.1: 60Mb+ traces have only 5-7 visible actions. Actually, they should contain thousands of them according to our logs and the actual work done. I have a related question: we have an important trace that was recorded on the broken version of PW 1.45.1. How can we fix this specific trace? It should contain all the required data according to its size. |
@diffusi-on could you please verify if it also happens on Canary? https://playwright.dev/docs/canary-releases |
@mxschmitt I'm not sure it will be easy to test since we are not using @playwright/test. We use Playwright more for RPA rather than testing. The project is deployed under Docker, so we are using the Docker image mcr.microsoft.com/playwright:v1.45.1 as the base. Should we add something like this to Dockerfile? |
RUN npm i -D playwright@next
RUN npx playwright install --with-deps This should do it. |
@mxschmitt "playwright": "^1.46.0-alpha-2024-07-10" - traces are still broken Can't provide the full trace, but can show a screenshot. For example, at this stage, the RPA filled the company search field, then clicked the company name. It was done, but not shown in the trace along with many (99% ? :) other actions. |
We unfortunately need something which we can run locally in order to act on it. Our canary received some more fixes, so maybe you could re-check again? If you are using
|
Hi! I experiencing the same problem on |
@deputat1000 Could you please share a repro with us so we can debug the problem? |
@dgozman sure
So, there are 4 actions. In trace 1.44.1 there will be the same 4 actions: |
@deputat1000 Thank you for the repro! I believe this is similar to #31764, which will be fixed shortly. Please follow that issue for now. |
Fixed in #31764 and released in v1.45.3. |
Last Good Version
1.44.1
First Bad Version
1.45.0
Steps to reproduce
Unfortunately I can't provide a repo with reproduction since the AUT is an internal app and I can't easily strip our node project down to the bare minimum. When you need to know certain options/settings I can provide them ofcourse.
The described problem is always reproducable in 1.45.0 (and 1.45.1) regardless of the following conditions/settings:
headless: true/false
browser: chrome/safari
trace options:
See attached tracefiles for a (minimal) example in 1.44.1 en 1.45.1.
Expected behavior
Tracefile shows all actions during test.
Actual behavior
Tracefile doesnt show all actions during test.
Additional context
see attached tracefiles
1.44.1.zip
1.45.1.zip
Environment
The text was updated successfully, but these errors were encountered: