Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[internal] PlzDedicatedWorker breaks worker networking #31747

Open
dgozman opened this issue Jul 18, 2024 · 2 comments · Fixed by #32711
Open

[internal] PlzDedicatedWorker breaks worker networking #31747

dgozman opened this issue Jul 18, 2024 · 2 comments · Fixed by #32711
Assignees
@dgozman
Labels
browser-chromium upstream This is a bug in something playwright depends on, like a browser. v1.50

Comments

@dgozman
Copy link
Contributor

dgozman commented Jul 18, 2024

See #31705 for a failed roll.

Two tests are failing:

  • [chromium-page] › page/interception.spec.ts:125:3 › should intercept network activity from worker 2
  • [chromium-page] › page/workers.spec.ts:228:3 › should support extra http headers

Regressed in https://chromium-review.googlesource.com/c/chromium/src/+/5671624 by enabling PlzDedicatedWorker feature.
Upstream issues:

Temporary resolution is to roll with PlzDedicatedWorker feature disabled, but we need upstream issues to be fixed and re-enable the feature.
@dgozman dgozman added the v1.47 label Jul 18, 2024
@dgozman dgozman self-assigned this Jul 18, 2024
@mxschmitt mxschmitt mentioned this issue Jul 18, 2024
Merged
mxschmitt pushed a commit that referenced this issue Jul 18, 2024
@dgozman
feat(chromium-tip-of-tree): roll to r1241 (#31748)
e78ce85 
Closes #31650
Closes #31705
Relates #31747
@mxschmitt mxschmitt added browser-chromium upstream This is a bug in something playwright depends on, like a browser. labels Jul 18, 2024
@dgozman
Copy link
Contributor Author

dgozman commented Aug 2, 2024

Fix landed as https://chromium-review.googlesource.com/c/chromium/src/+/5748510, should go into Chromium 129.

@dgozman dgozman added v1.48 and removed v1.47 labels Aug 22, 2024
@dgozman dgozman mentioned this issue Sep 19, 2024
Merged
@dgozman dgozman mentioned this issue Oct 15, 2024
Merged
@dgozman dgozman reopened this Oct 15, 2024
@dgozman dgozman added v1.49 and removed v1.48 labels Oct 15, 2024
@dgozman
Copy link
Contributor Author

dgozman commented Nov 11, 2024

Filed upstream issue https://issues.chromium.org/u/1/issues/378421877.

@mxschmitt mxschmitt added v1.50 and removed v1.49 labels Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dgozman dgozman

Labels
browser-chromium upstream This is a bug in something playwright depends on, like a browser. v1.50
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(chromium): allow PlzDedicatedWorker dgozman/playwright
2 participants
@dgozman @mxschmitt