[Bug]: * is not iterable when using option: true

[bloodgang94]

Note from maintainers

To provide an option that is an array of objects, use the long-form notation by wrapping the value into an array:

// Option that is an array of objects.
const optionValue = [{ key: 'value1' }, { key: 'value2' }];
test.use({
  // Wrap the value into an array and pass the scope.
  myOption: [optionValue, { scope: 'test' }],
});

---

Version

1.46.0

Steps to reproduce

1. Clone repository https://github.com/bloodgang94/pw-not-iterable-reproduction-steps.git
2. Run npm i
3. Run tests npx playwright test

spec.ts

import { test, expect } from "@/fixtures/navigate-fixture";

test.use({ links: [{ name: "API" }, { name: "Docs" }] });

test("get started link", async ({ page }) => {
  await expect(page).toHaveURL("https://playwright.dev/docs/input");
});

fixture

import { test as base, Page } from "@playwright/test";

export type NavigateFixture = {
  links: { name: string }[];
  page: Page;
};

export const test = base.extend<NavigateFixture>({
  links: [[{ name: "" }], { option: true }],
  page: async ({ page, links }, use) => {
    await page.goto("/");
    for (const link of links)
      await page
        .getByRole("link", { name: link.name })
        .press("Control+ArrowRight");
    await use(page);
  },
});

export * from "@playwright/test";

Expected behavior

Fixture code completed

Actual behavior

TypeError: links is not iterable

Additional context

There was no such problem in version 1.45.There was no such problem in version 1.45. In debugging I see that it is not an array, but an element of an array

Environment

OS: Win 10, 16 RAM, VS Code 1.92.0

[msilviudan]

This bug will brake all the tests that are using arrays of objects in the fixture.

[dgozman]

@bloodgang94 While we are figuring this out, you can do the following as a workaround:

test.use({ links: [[{ name: "API" }, { name: "Docs" }], { scope: 'test' }] });

[sergtimosh]

@dgozman am I right that doble array workaround passes two-dimentional array into the fixture and we need to strip it to use properly?