-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: 1.46.0 (TypeScript) - custom fixtures extend
no longer chainable?
#32056
Labels
Comments
dgozman
added a commit
to dgozman/playwright
that referenced
this issue
Aug 8, 2024
… support TS 5.5 Regressed in microsoft#31532. The TS5.5 changes broke chaining of `extend`s where the first `extend` did not specify any type arguments. Fixes microsoft#32056.
kodiakhq bot
referenced
this issue
in cloudquery/cloudquery
Sep 1, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@playwright/test](https://playwright.dev) ([source](https://togithub.com/microsoft/playwright)) | devDependencies | patch | [`1.46.0` -> `1.46.1`](https://renovatebot.com/diffs/npm/@playwright%2ftest/1.46.0/1.46.1) | | [@playwright/test](https://playwright.dev) ([source](https://togithub.com/microsoft/playwright)) | devDependencies | minor | [`1.45.3` -> `1.46.1`](https://renovatebot.com/diffs/npm/@playwright%2ftest/1.45.3/1.46.1) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>microsoft/playwright (@​playwright/test)</summary> ### [`v1.46.1`](https://togithub.com/microsoft/playwright/releases/tag/v1.46.1) [Compare Source](https://togithub.com/microsoft/playwright/compare/v1.46.0...v1.46.1) ##### Highlights [https://github.com/microsoft/playwright/issues/32004](https://togithub.com/microsoft/playwright/issues/32004) - \[REGRESSION]: Client Certificates don't work with Microsoft IIS[https://github.com/microsoft/playwright/issues/32004](https://togithub.com/microsoft/playwright/issues/32004)4 - \[REGRESSION]: Websites stall on TLS handshake errors when using Client Certificate[https://github.com/microsoft/playwright/issues/32146](https://togithub.com/microsoft/playwright/issues/32146)46 - \[BUG]: Credential scanners warn about internal socks-proxy TLS certificat[https://github.com/microsoft/playwright/issues/32056](https://togithub.com/microsoft/playwright/issues/32056)056 - \[REGRESSION]: 1.46.0 (TypeScript) - custom fixtures extend no longer chaina[https://github.com/microsoft/playwright/issues/32070](https://togithub.com/microsoft/playwright/issues/32070)2070 - \[Bug]: --only-changed flag and project dependen[https://github.com/microsoft/playwright/issues/32188](https://togithub.com/microsoft/playwright/issues/32188)32188 - \[Bug]: --only-changed with shallow clone throws "unknown revision" error ##### Browser Versions - Chromium 128.0.6613.18 - Mozilla Firefox 128.0 - WebKit 18.0 This version was also tested against the following stable channels: - Google Chrome 127 - Microsoft Edge 127 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on the first day of the month" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).
This was referenced Sep 7, 2024
This was referenced Sep 7, 2024
This was referenced Sep 24, 2024
Open
Open
This was referenced Sep 26, 2024
This was referenced Sep 27, 2024
Open
Open
Open
Open
Open
Open
This was referenced Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Version
1.46.0
Steps to reproduce
https://github.com/halljus/playwright-bug-repro(deleted now that issue is closed)npm install
npm run typecheck
test.extend
that is a child of anextend
without a generic type parameter are typed asany
.Expected behavior
I expect parameters passed to a child
extend<MyFixtures>
with atest.extend
parent to be fully typed as they were prior to v1.46.0.Actual behavior
As of v1.46.0, any
extend<MyFixtures>
with a generic type parameter that follow a parenttest.extend
without a generic type parameter will receive untyped arguments (they'll be of typeany
).Additional context
I can "fix" this by moving the
extend
without the generic type parameter AFTER theextend<MyFixtures>
, but a) it worked before, and b) I'm not sure if that's equivalent behavior.Environment
The text was updated successfully, but these errors were encountered: