Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Scrollbars are not hidden #3330

Closed
Anrb13 opened this issue Aug 6, 2020 · 9 comments
Closed

[BUG] Scrollbars are not hidden #3330

Anrb13 opened this issue Aug 6, 2020 · 9 comments
Assignees

Comments

@Anrb13
Copy link

Anrb13 commented Aug 6, 2020

Context:

  • Playwright Version: @1.2.1
  • Operating System: Windows
  • Node.js version: v12.18.2
  • Browser: WebKit iPhone

scrollbars are not hidden
2020-08-06T18-33-08 939Z_iphone
2020-08-06T18-16-49 254Z_iphone
2020-08-06T18-30-24 798Z_iphone
2020-08-06T18-32-21 374Z_iphone

@Anrb13 Anrb13 changed the title [BUG] WebKit Devices[iPhone] scrollbars are not hidden [BUG] Scrollbars are not hidden Aug 6, 2020
@Anrb13
Copy link
Author

Anrb13 commented Aug 6, 2020

same at desktop
2020-08-06T19-12-34 972Z_webkit_EMPTY_A1_VAR
2020-08-06T19-12-34 972Z_webkit_EMPTY_A2_VAR

@yury-s
Copy link
Member

yury-s commented Aug 10, 2020

@Anrb13 can you share you code snippet? I tried to reproduce it with the following code in Playwright 1.2.1 and 1.3.0:

const { webkit, devices } = require('playwright');
const iPhone11 = devices['iPhone 11'];

(async () => {
  const browser = await webkit.launch({
     headless: false,
  });
  const context = await browser.newContext({
    ...iPhone11,
    locale: 'ru-RU',
  });
  const page = await context.newPage();
  await page.goto('https://www.wildberries.ru/');
  await page.screenshot({ path: 'w.png' });
  await browser.close();
})();

The result image doesn't contain any scrollbars:
w

@Anrb13
Copy link
Author

Anrb13 commented Aug 10, 2020

I tried to localize problem, think its about cookie dat i add in test, but no,
have scrollbars on same code
`const { webkit, devices } = require('playwright');
const iPhone11 = devices['iPhone 11'];

(async () => {
const browser = await webkit.launch({
headless: false,
});
const context = await browser.newContext({
...iPhone11,
locale: 'ru-RU',
});
const page = await context.newPage();
await page.goto('https://www.wildberries.ru/', { waitUntil: 'networkidle' });
await page.screenshot({ path: 'w.png' });
await browser.close();
})();`
w
Update playwright to 1.3.0, same result

@Anrb13
Copy link
Author

Anrb13 commented Aug 10, 2020

AND, your screenshot have white space too, wildberries app looks like (didn't see it right away):
image

@yury-s
Copy link
Member

yury-s commented Aug 10, 2020

@Anrb13 did you attach correct screenshot? I don't see scrollbars on this image. The page layout seems a bit off indeed but this is likely a different issue. I'd like to first reproduce the scrollbars problem if it still exists.

@Anrb13
Copy link
Author

Anrb13 commented Aug 10, 2020

https://github.com/Anrb13/testsm - my repo, if it helps,
have issue on desktop/screen.test.js and mobile/screen.test.js
different behavior: scrollbars were cut of, black or not hidden, like on my first message.

@yury-s
Copy link
Member

yury-s commented Aug 11, 2020

Thanks for sharing the repo, I managed to reproduce it with the sportmaster site. Looks like the particular state that depends on the cookies is important. This is clearly a bug in the Windows port of WebKit we ship. Also the picture that I see on the screenshot:

webkit_iPhone 8_EMPTY_A1_VAR

has nothing to do with what I see on the screen:
image

@yury-s yury-s added the v1.4 label Aug 24, 2020
@arjunattam
Copy link
Contributor

Screen Shot 2020-09-02 at 11 40 02 AM

Seeing the same behavior on apple.com launched with playwright-cli@0.2.0

@yury-s
Copy link
Member

yury-s commented Sep 8, 2020

Should be fixed now.

@yury-s yury-s closed this as completed Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants