feat(cr, wk): make clicks, input and evaluate await scheduled navigations #1200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelfeldman
force-pushed
the
wait_click
branch
5 times, most recently
from
117816e to
05c0b3d
Compare
test/navigation.spec.js
Outdated
| await page.setContent(`<a href="${server.PREFIX}/wasm/table2.wasm" download=true>table2.wasm</a>`); | ||
| await page.click('a'); | ||
| }); | ||
| it.fail(CHROMIUM || FFOX)('should not hang on window.stop', async({page, server, httpsServer}) => { |
There was a problem hiding this comment.
I don't feel comfortable landing this patch until this test passes.
There was a problem hiding this comment.
That's too bad, because it does not pass without my patch either.
There was a problem hiding this comment.
Interesting! Something stalled the evaluation?
pavelfeldman
changed the title
pavelfeldman
force-pushed
the
wait_click
branch
3 times, most recently
from
dcbc412 to
363cdd1
Compare
pavelfeldman
changed the title
dgozman
approved these changes
Mar 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.